Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Memberlist dependency version bump to k108 #6773

Conversation

JordanRushing
Copy link
Contributor

Signed-off-by: JordanRushing rushing.jordan@gmail.com

What this PR does / why we need it:

This PR backports the changes in #6717 to the k108 release.

Which issue(s) this PR fixes:

Fixes mimir/#2401.

Special notes for your reviewer:

N/A

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
@JordanRushing JordanRushing requested a review from a team as a code owner July 26, 2022 15:55
@JordanRushing JordanRushing self-assigned this Jul 26, 2022
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@JordanRushing JordanRushing merged commit ef51858 into grafana:main Jul 26, 2022
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distributors not leaving the ring on shutdown when memberlist is used
3 participants