[bugfix] fixes issues sharding series by storageref vs fingerprint in… #6882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… stripeSeries
I noticed a
concurrent map read/write
panic coming from ourstripeSeries
code atReading over the code, I realized we were using the same lock index during
Append
calls, which is incorrect. To fix this problem and make the code a bit easier to work with, I embeddedRWLock
s in both theseriesHashmap
and thememSeriesMap
. This way, we don't reuse the same locks for both purposes, as theseriesHashmap
s are sharded byfingerprint
whereas thememSeriesMap
s are sharded byStorageRef
.ref #5428