Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(embedded-cache): Add missing docs on config page. #7684

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Nov 14, 2022

What this PR does / why we need it:
Adds embedded-cache config under cache_config section. Also adds message about deprecation of fifocache

Which issue(s) this PR fixes:
Fixes #7677

Special notes for your reviewer:

Checklist

  • Documentation added
  • CHANGELOG.md updated

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 14, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 14, 2022
Adds `embedded-cache` config under `cache_config` section.
Also adds message about deprecation of `fifocache`
@kavirajk kavirajk marked this pull request as ready for review November 14, 2022 08:33
@kavirajk kavirajk requested a review from a team as a code owner November 14, 2022 08:33
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavirajk kavirajk added the backport release-2.7.x add to a PR to backport it into release 2.7.x label Nov 14, 2022
@kavirajk kavirajk merged commit 7073ea8 into main Nov 14, 2022
@kavirajk kavirajk deleted the kavirajk/doc-embedded-cache branch November 14, 2022 10:36
grafanabot pushed a commit that referenced this pull request Nov 14, 2022
**What this PR does / why we need it**:
Adds `embedded-cache` config under `cache_config` section. Also adds
message about deprecation of `fifocache`

**Which issue(s) this PR fixes**:
Fixes #7677

**Special notes for your reviewer**:

**Checklist**
- [x] Documentation added
- [x] `CHANGELOG.md` updated

(cherry picked from commit 7073ea8)
kavirajk added a commit that referenced this pull request Nov 14, 2022
#7687)

Backport 7073ea8 from #7684

Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
**What this PR does / why we need it**:
Adds `embedded-cache` config under `cache_config` section. Also adds
message about deprecation of `fifocache`

**Which issue(s) this PR fixes**:
Fixes grafana#7677 

**Special notes for your reviewer**:

**Checklist**
- [x] Documentation added
- [x] `CHANGELOG.md` updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.7.x add to a PR to backport it into release 2.7.x size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embedded-cache as replacement for fifoache not documented
3 participants