New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loki: Add route_randomly to Redis options #8852
Loki: Add route_randomly to Redis options #8852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please just add some more documentation
Thanks for the contribution @wtchangdm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I touched up the wording a little.
Please merge main
into your branch and rerun make doc
and commit the result.
Co-authored-by: Danny Kopping <dannykopping@gmail.com>
Thanks @dannykopping, I've regenerated the doc and rebased on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks again @dannykopping! |
What this PR does / why we need it:
Current Redis client only reads from master node, which makes master node under heavy pressure.
Usually, one or more read replicas are expected on production environments.
This PR helps to increase the utilization of read replicas.
Which issue(s) this PR fixes:
Fixes #8811
Special notes for your reviewer:
route_randomly
option defaults tofalse
, which matches the same behavior in previous versions, hence no breaking change.route_randomly
totrue
in order to use it.RouteRandomly
is used and not the following:ReadOnly
(which only reads from read replicas)RouteByLatency
(requests probably won't be even since not all Loki components are deployed evenly separate)Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updateddocs/sources/upgrading/_index.md