Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packaging): Dockerfile make avoid containers #887

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

slim-bean
Copy link
Collaborator

No description provided.

…so we need to specify BUILD_IN_CONTAINER=false to make sure we don't try to run a docker container from within our build container
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sh0rez sh0rez changed the title make targets in dockerfiles should specify BUILD_IN_CONTAINER=false chore(packaging): Dockerfile make BUILD_IN_CONTAINER=false Aug 12, 2019
@sh0rez sh0rez changed the title chore(packaging): Dockerfile make BUILD_IN_CONTAINER=false chore(packaging): Dockerfile make avoid containers Aug 12, 2019
@sh0rez sh0rez merged commit 4eddcc1 into master Aug 12, 2019
@rfratto rfratto deleted the dockerfile-build-in-container branch November 1, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants