Short circuit parsing when label matchers are present #8890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes parsers aware of any downstream label-matcher stages at parse time. As labels are parsed, if one has a matcher, the matcher is checked at parse time. If the label does not match it's matcher, parsing is halted on that log line.
ex 1:
consider the log:
foo=1 bar=2 baz=3
And the query
{} | logfmt | bar=3
When
bar
is parsed it is immediately checked against it's matcher. The match fails so we the parser never spends time parsing the rest of the line.ex 2:
consider the log:
foo=1 baz=3 bletch=4
And the query
{} | logfmt | bar=3
bar
is never seen in the log so the whole line is parsed.Benchmarks: