Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci/cd): build containers using drone.io #891

Merged
merged 5 commits into from
Aug 15, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Aug 13, 2019

Because of the native arm capabilities, this now builds the containers using
drone.io as well.

Note: drone.yml is autogenerated using jsonnet

@sh0rez sh0rez self-assigned this Aug 13, 2019
@sh0rez sh0rez added component/packaging type/enhancement Something existing could be improved labels Aug 13, 2019
Because of the native arm capabilities, this now builds the containers using
drone.io as well.
Prevents drone from actually publishing anything, but rather just do as-if,
until we are certain that it should replace CircleCI
@sh0rez sh0rez marked this pull request as ready for review August 14, 2019 12:31
@sh0rez
Copy link
Member Author

sh0rez commented Aug 14, 2019

This thing can be reviewed now.

To see an real example, https://github.com/tbraack/tanka can be used.
CI ran here: https://cloud.drone.io/tbraack/loki/30, and deployed here: https://cloud.docker.com/u/shorez/repository/docker/shorez/loki

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to faster builds!

@sh0rez
Copy link
Member Author

sh0rez commented Aug 14, 2019

Delaying the merge of this one until Drone is enabled for this repository

@sh0rez sh0rez merged commit 45bdebf into grafana:master Aug 15, 2019
@sh0rez sh0rez deleted the drones-everywhere branch August 15, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants