Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move promtail doc into dedicated subfolder #933

Merged

Conversation

pracucci
Copy link
Contributor

What this PR does / why we need it:

In a previous doc review, @slim-bean mentioned:

I think the goal with another PR is to move all the promtail specific docs into a promtail folder

In this PR I'm proposing a way to move such doc. I keep the entrypoint promtail.md in the root doc folder and replaced links.

Checklist

  • Documentation added
  • Tests updated

@cyriltovena
Copy link
Contributor

@rfratto since you wanted to take on documentation, you should review this one.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pracucci! I need to wait on merging this but I'll merge it ASAP.

@rfratto rfratto merged commit cae0491 into grafana:master Sep 3, 2019
@pracucci pracucci deleted the move-promtail-doc-to-dedicated-folder branch September 5, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants