Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendoring: update cortex to latest master #938

Merged
merged 6 commits into from
Aug 28, 2019

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Pull in latest Cortex master

While updating Cortex, had to do following changes to use the right version:

v3.4.0-rc.1 for go.etcd.io/etcd
v0.0.2 for github.com/prometheus/procfs
v1.0.0 for github.com/prometheus/client_golang
the latest master for github.com/weaveworks/common with changes from weaveworks/common#153

using v3.4.0-rc.1 for go.etcd.io/etcd
v0.0.2 for github.com/prometheus/procfs
v1.0.0 for github.com/prometheus/client_golang
latest master for github.com/weaveworks/common with changes from weaveworks/common#153
@cyriltovena
Copy link
Contributor

can you try to make the build pass ?

Gopkg.toml Show resolved Hide resolved
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants