Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync release pkgs name with release note #958

Merged
merged 1 commit into from
Sep 5, 2019
Merged

sync release pkgs name with release note #958

merged 1 commit into from
Sep 5, 2019

Conversation

daixiang0
Copy link
Contributor

In release note(tools/release-note.md):

#### Binary:
```bash
# download a binary (adapt app, os and arch as needed)
$ curl -fSL -o "/usr/local/bin/loki.gz" "https://github.com/grafana/loki/releases/download/${CIRCLE_TAG}/loki-linux-amd64.gz"
$ gunzip "/usr/local/bin/loki.gz"

So sync it.

Signed-off-by: Xiang Dai 764524258@qq.com

@daixiang0
Copy link
Contributor Author

@slim-bean @cyriltovena Hi, please re-release it or users can not get true pkgs.

@daixiang0
sync release pkgs name with release note
9bd202b 
Signed-off-by: Xiang Dai <764524258@qq.com>
slim-bean
slim-bean approved these changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, LGTM

@slim-bean slim-bean merged commit 2064f91 into grafana:master Sep 5, 2019
@daixiang0 daixiang0 deleted the sync-release branch September 6, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daixiang0 @slim-bean