Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate label values from ingester streams #9629

Merged
merged 3 commits into from Jun 5, 2023
Merged

Fix duplicate label values from ingester streams #9629

merged 3 commits into from Jun 5, 2023

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Jun 5, 2023

What this PR does / why we need it:
Using the label values matchers exposed by #8824 introduces duplicate label values when the lookup goes through the ingester. This PR deduplicates label values when matching active streams and in turn aligns the behavior with the series_index_stores.go. Latter is used actively by the querier to lookup label values with matchers.

screenshot-1

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@periklis periklis requested a review from a team as a code owner June 5, 2023 12:52
@periklis periklis self-assigned this Jun 5, 2023
@grafanabot
Copy link
Collaborator

Hello @periklis!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 5, 2023
@dannykopping dannykopping added the type/bug Somehing is not working as expected label Jun 5, 2023
dannykopping
dannykopping approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@periklis periklis merged commit 69392de into grafana:main Jun 5, 2023
4 of 5 checks passed
@grafanabot grafanabot mentioned this pull request Jun 5, 2023
Merged
grafanabot pushed a commit that referenced this pull request Jun 5, 2023
@periklis @grafanabot
Fix duplicate label values from ingester streams (#9629)
10c5dd2 
(cherry picked from commit 69392de)
periklis added a commit that referenced this pull request Jun 6, 2023
@grafanabot @periklis
[release-2.8.x] Fix duplicate label values from ingester streams (#9631)
f88e3cd 
Backport 69392de from #9629

---------

Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@periklis periklis

Labels
backport release-2.8.x size/S type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @grafanabot @dannykopping