Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(distributor): parseError BadRequest #975

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Sep 5, 2019

When the label validation in the distributor failed, it was reported as 500 Internal Server Error instead of 400 BadRequest.

Fixes #929

pkg/distributor/http.go Outdated Show resolved Hide resolved
@sh0rez sh0rez self-assigned this Sep 10, 2019
When the label validation in the distributor failed, it was reported as 500
Internal Server Error instead of 400 BadRequest. Fixes that.
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sh0rez sh0rez merged commit 3467440 into grafana:master Sep 10, 2019
@chaudum chaudum added the type/bug Somehing is not working as expected label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/loki type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loki returns 500 code for parse error in labels
4 participants