Documentation Rewrite #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
docs-rewrite
branch
from
d5c9a70
to
e7b62f2
Compare
rfratto
force-pushed
the
docs-rewrite
branch
from
5641bdb
to
1a879bf
Compare
sh0rez
added
component/docs
type/enhancement
rfratto
force-pushed
the
docs-rewrite
branch
2 times, most recently
from
85aff06
to
7e6d101
Compare
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
cyriltovena
reviewed
Sep 11, 2019
rfratto
force-pushed
the
docs-rewrite
branch
3 times, most recently
from
9f6972a
to
65c0518
Compare
|
This is ready for review. I'm looking for any and all feedback about content, formatting, etc.! |
slim-bean
reviewed
Sep 18, 2019
slim-bean
reviewed
Sep 18, 2019
slim-bean
reviewed
Sep 18, 2019
slim-bean
reviewed
Sep 18, 2019
slim-bean
reviewed
Sep 18, 2019
slim-bean
reviewed
Sep 18, 2019
slim-bean
reviewed
Sep 18, 2019
rfratto
force-pushed
the
docs-rewrite
branch
from
26a21fe
to
9c432f3
Compare
|
So at this point I think this is ready for a final look-over and a merge. I'm sure there's always going to be some areas to improve the documentation, but I don't want this sitting around forever and I think this is good progress for the docs. Please open new issues for new improvements once this is finally merged 🙂 /cc @cyriltovena |
|
Congrats on merging, this was a huge effort on your part and updated docs look great! |
|
Thanks @rfratto for patiently addressing my feedback. You did a great job! 👏 👏 👏 |
Closed
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Make Cache a generic interface which FiFo also implements Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Make index cache use the generic interface Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add memcache as a cache option to the Index Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Handle unicode with hack. Memcache cannot deal with it. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Do client side expiry validation as write back might skew times Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add metrics Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * protobuf and review feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites and restructures all of the documentation with the following goals:
Closes #94