add stats, volume, and volume_range commands to logcli #9966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
changed the title
MasslessParticle
approved these changes
Jul 18, 2023
cmd/logcli/main.go
Outdated
| statsCmd = app.Command("stats", `Run a stats query. | ||
|
|
||
| The "stats" command will take the provided query and return statistics | ||
| from the index for how much data that query will hit. This only works |
There was a problem hiding this comment.
for how much data that query will hit
This is only meaningful in the context of the ui. Probably want to say something like "how much data is contained in the streams defined by the selector for the time range"
|
Looks good. Just a small note on wording |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
stats,volume, andvolume_rangecommands tologcli.Does not implement the file client for now. I think it would be cool if in the future the file client could read from a downloaded TSDB index file for these commands.