make []schema.Point msgp decoding use the pointslicepool

this should help reduce memory usage in query nodes when they decode /getdata requests coming back
grafana · Oct 15, 2020 · de35bcf · de35bcf
1 parent 56f0106
commit de35bcf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/api/models/init_test.go b/api/models/init_test.go
@@ -0,0 +1,7 @@
+package models
+
+import "github.com/grafana/metrictank/pointslicepool"
+
+func init() {
+	pointSlicePool = pointslicepool.New(100)
+}
diff --git a/api/models/series_msgp_manual.go b/api/models/series_msgp_manual.go
@@ -1,7 +1,6 @@
 package models
 
 import (
-	"github.com/grafana/metrictank/schema"
 	"github.com/tinylib/msgp/msgp"
 )
 
@@ -136,7 +135,7 @@ func (z *Series) DecodeMsg(dc *msgp.Reader) (err error) {
 			if cap(z.Datapoints) >= int(zb0004) {
 				z.Datapoints = (z.Datapoints)[:zb0004]
 			} else {
-				z.Datapoints = make([]schema.Point, zb0004)
+				z.Datapoints = pointSlicePool.GetMin(int(zb0004))[:zb0004]
 			}
 			for za0004 := range z.Datapoints {
 				err = z.Datapoints[za0004].DecodeMsg(dc)
@@ -512,7 +511,7 @@ func (z *Series) UnmarshalMsg(bts []byte) (o []byte, err error) {
 			if cap(z.Datapoints) >= int(zb0004) {
 				z.Datapoints = (z.Datapoints)[:zb0004]
 			} else {
-				z.Datapoints = make([]schema.Point, zb0004)
+				z.Datapoints = pointSlicePool.GetMin(int(zb0004))[:zb0004]
 			}
 			for za0004 := range z.Datapoints {
 				bts, err = z.Datapoints[za0004].UnmarshalMsg(bts)