Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

MetricData messages in mdm topic poorly defined. make versioning explicit? #2028

Closed
Dieterbe opened this issue Feb 8, 2022 · 0 comments · Fixed by #2029
Closed

MetricData messages in mdm topic poorly defined. make versioning explicit? #2028

Dieterbe opened this issue Feb 8, 2022 · 0 comments · Fixed by #2029
Labels

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Feb 8, 2022

see discussion at #2011 (comment)

MetricData is currently assumed, not explicitly defined via a format byte. In practice, the first byte will typically be 0x89, but as @shanson7 points out, there could be a bit of a wider range in play in practice for users who have their own custom publishers that don't encode full MetricData payloads. I'm not aware of anying doing that, all "official" tools use 0x89, and all official docs refer to encoding the full MetricData payload, so it seems like a fair position to assume anything but 0x89 is unsupported. OTOH, in practice, tolerating the wider range wouldn't really cost us anything.

@Dieterbe Dieterbe added the bug label Feb 8, 2022
Dieterbe added a commit that referenced this issue Feb 10, 2022
Dieterbe added a commit that referenced this issue Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant