This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Use non-blocking write to flushed #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are hitting the timeout. Just running the memory tests locally takes over a minute, almost entirely in With additional testing, perhaps we should raise the timeouts or run some tests in parallel. Either way, succeeded in 9 min 51 sec (9 whole seconds to spare!) on the second run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1836
Simplest change is to use a non-blocking write to the
flushedchan. Possibly more ideal would be for theQueueing thread to trigger a flush, rather than flush manually, but that would be a larger change that would need more proof of correctness.