This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Return 403 instead of 413 when limit exceeded #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i found 4 hits for http.StatusRequestEntityTooLarge, all seem to be related to checking for this limit, or a similar one. |
|
Sure, I will update them all. |
HTTP response code 413 should be per RFC7231 returned when request payload is too large and not when request causes dataset too large to process. HTTP response 403 Forbidden is more appropriate here as it means that server understood the request, but is refusing to fulfill it. Closes: #1969 Signed-off-by: Ondrej Balaz <blami@blami.net>
robert-milan
approved these changes
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP response code 413 should be per RFC7231 returned when request
payload is too large and not when request causes dataset too large to process.
HTTP response 403 Forbidden is more appropriate here as it means that
server understood the request, but is refusing to fulfill it.
Closes: #1969