You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curious if @joe-elliott has any suggestions here.
Joe, if we want to emit log messages and somehow correlate messages corresponding to the same request together, what would you recommend? I know in jaeger land, you'd attach the log messages to the trace (i believe they get sent in the span data) but that makes us depend on jaeger, which is a heavy/expensive dependency we rather not enforce.
Shall we just log the trace ID in the log message and write it out to a file/stdout? AFAIK loki doesn't have a way to join messages by traceID (but it does have a way to filter by trace ID, and we could join in a log analysis script). Does tempo try to solve this at all?
Tempo also stores and returns "logs" or "events" like Jaeger. So you can continue attaching your logs to the spans and they will be retrieved when you request the trace.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1973