Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Render format csv #1975

Merged
merged 3 commits into from
May 4, 2021
Merged

Render format csv #1975

merged 3 commits into from
May 4, 2021

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented May 4, 2021

most of the code is copy pasted from the json and pickle format (e.g. all the benchmarking boilerplate), so this should be easy to review (just focus on the csv specific bits)

tested with docker-dev. seems to work fine.

$ curl 'http://localhost:6060/render?target=metrictank.stats.docker-env.default.tank.metrics_active.gauge32&from=-10s&format=csv' 
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:46:54,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:46:55,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:46:56,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:46:57,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:46:58,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:46:59,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:47:00,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:47:01,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:47:02,614
metrictank.stats.docker-env.default.tank.metrics_active.gauge32,2021-05-04 12:47:03,614
$ curl 'http://localhost:6060/render?target=metrictank.stats.docker-env.default.tank.metrics_active.gauge32&from=-10s&format=json'
[{"target":"metrictank.stats.docker-env.default.tank.metrics_active.gauge32","tags":{"name":"metrictank.stats.docker-env.default.tank.metrics_active.gauge32"},"datapoints":[[614,1620132414],[614,1620132415],[614,1620132416],[614,1620132417],[614,1620132418],[614,1620132419],[614,1620132420],[614,1620132421],[614,1620132422],[614,1620132423]]}]

@Dieterbe Dieterbe requested a review from robert-milan May 4, 2021 11:49
Copy link
Contributor

@robert-milan robert-milan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one comment.

api/models/series.go Show resolved Hide resolved
@Dieterbe Dieterbe merged commit 50c558f into master May 4, 2021
@Dieterbe Dieterbe deleted the render-format-csv branch May 4, 2021 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants