This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
/tags/delByQuery: support for archiving metrics, not just deletion #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you update the |
Dieterbe
reviewed
May 18, 2021
| deleted, err := s.MetricIndex.DeleteTagged(request.OrgId, query) | ||
| return len(deleted), err | ||
| } | ||
| matched, _ := s.MetricIndex.FindTerms(request.OrgId, []string{}, query) | ||
| return int(matched), nil | ||
| return 0, fmt.Errorf("Unknown delete method '%s'", request.Method) |
There was a problem hiding this comment.
pretty sure the model validation already takes care of this case. but anyway, doesn't hurt.
There was a problem hiding this comment.
Model validation takes care of this when this code and the validation code agree. This is just defensive handling in case these code sections accidentally get out of sync.
Dieterbe
reviewed
May 18, 2021
| @@ -162,14 +162,16 @@ type IndexTagDelByQuery struct { | |||
| OrgId uint32 `json:"orgId" binding:"Required"` | |||
| Expr []string `json:"expressions" binding:"Required"` | |||
| OlderThan int64 `json:"olderThan" form:"olderThan"` | |||
| Execute bool `json:execute binding:"Default(false)"` | |||
| Execute bool `json:"execute" binding:"Default(false)"` | |||
There was a problem hiding this comment.
perhaps we need another static validator to catch typos like this
Dieterbe
suggested changes
May 18, 2021
Dieterbe
approved these changes
May 18, 2021
Dieterbe
changed the title
|
Thanks @Dieterbe! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1977