This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
correct Metricdef.LastUpdate when loading from persistent index #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(instead of at previous fix, which did it at query time for Find(), see #1532) This has two main benefits: 1) by making the change to the data, it works equally well across all types of queries, in particular this fixes the behavior for TagQuery 2) we no longer over-eagerly adjust the check at query time (if MT has seen a new point for a given metric - e.g. if the process has been up for a while - than the LastUpdate value in the memory index is perfectly accurate, and we don't need to make any adjustment) fix #1979
shanson7
approved these changes
Jun 3, 2021
|
Thanks for that quick turnaround! I know a couple of users that will be glad for this fix when we roll it out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(instead of at previous fix, which did it at query time for Find(),
see #1532)
This has two main benefits:
types of queries, in particular this fixes the behavior for TagQuery
seen a new point for a given metric - e.g. if the process has been up for
a while - than the LastUpdate value in the memory index is perfectly
accurate, and we don't need to make any adjustment)
fix #1979