This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 106
control server to initiate additions, deletes and archivals of metricdefinitions + findSeries 'full-json' format and 'To' flag #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Dieterbe - I know this is a lot to review. If you want, I can split it into pieces merging into a feature branch. Logical chunking would probably be:
Let me know if you would prefer that. |
would you say that reviewing commit by commit is also a good way to split it up? if so, i can just do that. |
Commit by commit tells the story. It's not the cleanest, but it could work. Thanks! |
Dieterbe
reviewed
Jul 28, 2021
Dieterbe
reviewed
Jul 28, 2021
Dieterbe
reviewed
Jul 28, 2021
Dieterbe
reviewed
Jul 28, 2021
@shanson7 seems like really good work! in line with our discussions, and more than i expected (e.g. delete and archive functionality rather than just revive) I left a bunch of comments, but nothing major. |
Dieterbe
reviewed
Jul 28, 2021
Dieterbe
reviewed
Aug 24, 2021
Dieterbe
reviewed
Aug 24, 2021
Dieterbe
reviewed
Aug 24, 2021
Dieterbe
reviewed
Aug 24, 2021
Co-authored-by: Dieter Plaetinck <dieter@plaetinck.be>
Dieterbe
approved these changes
Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1976
This PR is fully functional and provides:
findSeries
(used by control server to resolve series to delete/archive)To
param infindSeries
(used to forolderThan
functionality indelByTagQuery
)There are still some TODOs, and probably needs some more testing and code cleanup, but I feel it's in a place that basic design/naming/structure reviews can be being.
Note: This is rebased on #1991