Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

control server to initiate additions, deletes and archivals of metricdefinitions + findSeries 'full-json' format and 'To' flag #1992

Merged
merged 39 commits into from
Aug 30, 2021

Conversation

shanson7
Copy link
Collaborator

@shanson7 shanson7 commented Jun 29, 2021

Resolves #1976

This PR is fully functional and provides:

  1. Control message support for index operations: add/delete/archive defs
  2. Adds a control server that is used to generate the control messages
  3. Adds "full-json" format to findSeries (used by control server to resolve series to delete/archive)
  4. Adds support for To param in findSeries (used to for olderThan functionality in delByTagQuery)

There are still some TODOs, and probably needs some more testing and code cleanup, but I feel it's in a place that basic design/naming/structure reviews can be being.

Note: This is rebased on #1991

@shanson7 shanson7 requested a review from Dieterbe June 29, 2021 09:09
@shanson7
Copy link
Collaborator Author

shanson7 commented Jul 1, 2021

@Dieterbe - I know this is a lot to review. If you want, I can split it into pieces merging into a feature branch.

Logical chunking would probably be:

  1. Changes for findSeries - To param and full-json format. (I might also consider adding a full-msgp format, since full-json is very large)
  2. Control message types and processing
  3. The control server

Let me know if you would prefer that.

@Dieterbe
Copy link
Contributor

Dieterbe commented Jul 7, 2021

would you say that reviewing commit by commit is also a good way to split it up? if so, i can just do that.

@shanson7
Copy link
Collaborator Author

shanson7 commented Jul 7, 2021

Commit by commit tells the story. It's not the cleanest, but it could work. Thanks!

kafka/cfg.go Show resolved Hide resolved
@Dieterbe
Copy link
Contributor

@shanson7 seems like really good work! in line with our discussions, and more than i expected (e.g. delete and archive functionality rather than just revive)

I left a bunch of comments, but nothing major.

@shanson7 shanson7 requested a review from Dieterbe August 17, 2021 13:41
idx/bigtable/bigtable.go Outdated Show resolved Hide resolved
Co-authored-by: Dieter Plaetinck <dieter@plaetinck.be>
@Dieterbe Dieterbe changed the title Round 1: Control server control server to initiate additions, deletes and archivals of metricdefinitions Aug 25, 2021
@Dieterbe Dieterbe changed the title control server to initiate additions, deletes and archivals of metricdefinitions control server to initiate additions, deletes and archivals of metricdefinitions + findSeries 'full-json' format and 'To' flag Aug 25, 2021
@Dieterbe Dieterbe merged commit 5c170f7 into grafana:master Aug 30, 2021
@shanson7 shanson7 deleted the control-server branch August 31, 2021 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to "revive" archived series
2 participants