This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Implement linearRegression natively #2017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
|
|
@djedruszczak if you want to rebase I'll get to this next_ |
* Add base implementation, lots todo * Pass start and end through context jankily * Use source timespan * Copy series, set tag * Rename, respect source start/end * Use binary search to find first data point * Some clean up, fix start bug * Make test stricter, fix bug * Add tests for invalid args * Move test, small clean up * Some cleanup * Some cleanup * Replace missing data points with NaN values * Rename foreceast * Use data point pool * Use range fors, fix linear regression tag and name * Set outgoing context from/to * Try to figure out why interval is wrong * Carpet bomb, pass correct timestamp to analysis * Sort of working with ranges * Fix datapoints size * Make output size consistent with Graphite * Remove interval deduction * Some cleanup * Some cleanup * Add output series to data map * Refactor tests * Math is hard * Add relative test * Add normalization test * Remove debug statement * Some cleanup * Some cleanup * Clean up input validation * Clean up documentation * Remove debug statement * Fix relative test * Some cleanup * Some cleanup * Replace normalization * Add linear regression benchmarks * Add base implementation, lots todo * Pass start and end through context jankily * Use source timespan * Copy series, set tag * Rename, respect source start/end * Use binary search to find first data point * Some clean up, fix start bug * Make test stricter, fix bug * Add tests for invalid args * Move test, small clean up * Some cleanup * Some cleanup * Replace missing data points with NaN values * Rename foreceast * Use data point pool * Use range fors, fix linear regression tag and name * Set outgoing context from/to * Try to figure out why interval is wrong * Carpet bomb, pass correct timestamp to analysis * Sort of working with ranges * Fix datapoints size * Make output size consistent with Graphite * Remove interval deduction * Some cleanup * Some cleanup * Add output series to data map * Refactor tests * Math is hard * Add relative test * Add normalization test * Remove debug statement * Some cleanup * Some cleanup * Clean up input validation * Clean up documentation * Remove debug statement * Fix relative test * Some cleanup * Some cleanup * Replace normalization * Add linear regression benchmarks * Use tz.GetFromTo * Set tz.TimeZone in tests * Fix bench * Remove invalid input tests * Update comment * Make stable
pub-djedruszczak
force-pushed
the
feature-linearRegression2
branch
from
23a1b78
to
ff24d1b
Compare
|
Rebased! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Any update? |
|
closing in favor of #2046 - I needed to update the tests to work locally with the newer versions of docker / docker compose |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the linearRegression function natively.
It depends on #2015, so I'll rebase once thats merged.