-
Notifications
You must be signed in to change notification settings - Fork 106
Add support for removeZeroSeries function #2034
Conversation
I don't see this function in graphite docs. Metrictank functions should also be in graphite. |
d22ee37
to
80b299e
Compare
This function is in go-graphite, which a customer is using so we need to support this function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but I would like to see the empty series case tested
255f2fb
to
b8976fc
Compare
b8976fc
to
e95acec
Compare
@replay, this PR is ready to go. @carrieedwards is not authorized to merge it. Can you grant her access? thanks! |
The PR should also update the table of functions here: https://github.com/grafana/metrictank/blob/master/docs/graphite.md#processing-functions As Sean pointed out, this function doesn't exist in Graphite. How would you feel about also contributing it to Graphite after merging this PR, for parity? |
I can contribute the same to Graphite as well. |
that would be great, thank you |
This PR adds support for removeZeroSeries in Graphite web, which operates similarly to removeEmptySeries, but instead checks data points in the series for values equal to 0, instead of values equal to math.NaN().