This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Add time ranges for tag requests #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
Accidentally removed
carrieedwards
approved these changes
Nov 28, 2022
jesusvazquez
approved these changes
Nov 28, 2022
replay
reviewed
Nov 28, 2022
replay
approved these changes
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding time ranges to the
GraphiteTags,GraphiteAutoCompleteTagsandGraphiteAutoCompleteTagValuesmodels. These are needed by GEM to decide what time range to return results for.The time range fields for
GraphiteTagsandGraphiteAutoCompleteTagswere originally added in #2013, though were removed in #2015. I'm not sure why they were removed, possibly because Metrictank doesn't use them.I've added comments explaining the fields to the models, but haven't updated docs as per #2013 (comment), "In metrictank we don't actually use the fields, so we don't need to really update docs."