-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old chunk mapper. #311
Conversation
a825b20
to
a2521b4
Compare
@codesome I've removed old chunk mapper in this PR, but now Would you please take a look at the failing tests? There seem to be small difference between old and new chunk mapper. I'll try to look at it as well, but you may have better idea about the differences between old and new chunk mapper (perhaps just the fact that new one is async is enough change to cause this). Failures: https://github.com/grafana/mimir-prometheus/runs/7728655169?check_suite_focus=true |
Fix is likely available in prometheus/prometheus#11075. |
prometheus/prometheus#11075 is same as the one in mimir-prometheus, and tests might fail for async queue there as well I think. In Prometheus the queue is disabled by default I believe. I will take a look at those tests in coming days. |
The last commit should fix the tests. I will merge on green (minus the unrelated lint failure) |
Thanks @codesome, much appreciated! I can take care of updating mimir-prometheus in Mimir as a next step. |
Another test failure because of some sorting issue. On it. |
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2ec5cc3
to
840f5db
Compare
This PR removes
OldChunkDiskMapper