Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make query-frontend.align-queries-with-step setting per tenant #6712

Closed
56quarters opened this issue Nov 22, 2023 · 0 comments · Fixed by #6714
Closed

Make query-frontend.align-queries-with-step setting per tenant #6712

56quarters opened this issue Nov 22, 2023 · 0 comments · Fixed by #6714
Assignees
@56quarters
Labels
component/query-frontend enhancement New feature or request

Comments

@56quarters
Copy link
Contributor

56quarters commented Nov 22, 2023 •
edited

Is your feature request related to a problem? Please describe.

We have an option -query-frontend.align-queries-with-step that adjusts the start/end times of a query to align them with the step. This allows the query results to be cached. It's disabled by default because it's a violation of the Prometheus conformance test.

Describe the solution you'd like

Disabled by default is the right choice, but there are some tenants that are OK with start/end times being automatically adjusted since it results in better performance. But we can't enable it just for those tenants, only at a cluster level. This effectively means it's never enabled.

Describe alternatives you've considered

N/A

Additional context

N/A
@56quarters 56quarters self-assigned this Nov 22, 2023
56quarters added a commit that referenced this issue Nov 22, 2023
@56quarters
Make align-queries-with-step a per-tenant setting
9e90486 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but were previously unable to set at the tenant level.

Fixes #6712
56quarters added a commit that referenced this issue Nov 22, 2023
@56quarters
Make align-queries-with-step a per-tenant setting
a2d5c75 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes #6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters mentioned this issue Nov 22, 2023
Merged
3 tasks
56quarters added a commit that referenced this issue Nov 23, 2023
@56quarters
Make align-queries-with-step a per-tenant setting
9b7fda1 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes #6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this issue Nov 23, 2023
@56quarters
Make align-queries-with-step a per-tenant setting
02885b1 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes #6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this issue Nov 23, 2023
@56quarters
Make align-queries-with-step a per-tenant setting
b0e763f 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes #6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this issue Nov 27, 2023
@56quarters
Make align-queries-with-step a per-tenant setting
91ce01b 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes #6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this issue Nov 28, 2023
@56quarters
Make align-queries-with-step a per-tenant setting (#6714)
f377e46 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes #6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
edwintye pushed a commit to edwintye/mimir that referenced this issue Dec 18, 2023
@56quarters @edwintye
Make align-queries-with-step a per-tenant setting (grafana#6714)
62b4dad 
Allow the start and end times of queries to be adjusted to be step-aligned
at a per-tenant level. Adjusting the start and end times to multiples of
the step allows for better caching in exchange for behavior that isn't allowed
by Prometheus compatibility testing. Some tenants are OK with that tradeoff
but we were previously unable to set at the tenant level.

Fixes grafana#6712

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@56quarters 56quarters

Labels
component/query-frontend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make align-queries-with-step a per-tenant setting grafana/mimir
1 participant
@56quarters