Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated panel type graph in mimir-mixin #7188

Closed
krajorama opened this issue Jan 22, 2024 · 3 comments · Fixed by #7413
Closed

Stop using deprecated panel type graph in mimir-mixin #7188

krajorama opened this issue Jan 22, 2024 · 3 comments · Fixed by #7413
Labels
good first issue Good for newcomers mixin

Comments

@krajorama
Copy link
Contributor

Describe the bug

Mimir mixin is using a deprecated Grafana UI panel type, causing the frontend to convert the dashboards all the time (or make user save it causing it to be out of sync with the source).

To Reproduce

See e.g. https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-compiled/dashboards/mimir-writes.json#L508

Expected behavior

Dashboards should use "timeseries" panel type instead but look the same.

Environment

Any.

Additional Context

The dashboards are generated from jsonnet in https://github.com/grafana/mimir/tree/main/operations/mimir-mixin using https://github.com/grafana/jsonnet-libs/tree/master/grafana-builder

@krajorama krajorama added good first issue Good for newcomers mixin labels Jan 22, 2024
@krajorama
Copy link
Contributor Author

Some work has been done on this already:
#2800
#6864
probably more

@jmichalek132
Copy link
Contributor

I would be willing to help with this one.

@narqo
Copy link
Contributor

narqo commented Feb 17, 2024

@jmichalek132 I'm working on that in #7413. If you could help with testing the changes, to possibly spot any unexpected discrepancies in the dashboards before/after, this would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers mixin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants