Dashboards: use timeseries panel to show exemplars #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
dashboard-timeseries-panel
branch
from
1824dba
to
7522570
Compare
I also did some comparison and this is the only difference I noticed (except exemplars, as expected). This is very curious because looks like the |
|
Thanks for reviews.
I spent a lot of time tweaking parameters to see if I could make the legend go away. |
bboreham
force-pushed
the
dashboard-timeseries-panel
branch
from
d2b1d47
to
6c93e26
Compare
pracucci
approved these changes
Aug 24, 2022
This is now "the default and primary way to visualize time series data": https://grafana.com/docs/grafana/latest/visualizations/time-series/ Uses upstream change grafana/jsonnet-libs#824 So far I have only changed the per-pod latency panels, as those are the ones where exemplars work.
bboreham
force-pushed
the
dashboard-timeseries-panel
branch
from
6c93e26
to
0af57ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now "the default and primary way to visualize time series data"; the 'graph' panel has been deprecated.
Uses upstream change grafana/jsonnet-libs#824
So far I have only changed the per-pod latency panels, as those are the ones where exemplars work.
Checklist
CHANGELOG.mdupdated