Upgrade Prometheus and add evaluation_delay in rule group config #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
|
I cannot run |
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
I ran |
Oh, thanks for running it. Just realised that the change in rules config is not part of Mimir config hence wont reflect. |
pracucci
approved these changes
Mar 14, 2022
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
|
@pracucci fixed the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrades Prometheus which has added evaluation_delay for the rule group. Now we don't need to manually add the delays to timestamps, hence removed it from here.
Which issue(s) this PR fixes or relates to
Fixes #1267
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]