Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for Alertmanager GRPC client and GET request concurrency #1547

Merged
merged 7 commits into from
Mar 31, 2022

Conversation

Logiraptor
Copy link
Contributor

@Logiraptor Logiraptor commented Mar 25, 2022

What this PR does

Exposes existing configuration via yaml and CLI flags:

  • Alertmanager GRPC Client config is re-used from dskit
  • Alertmanager Concurrency is exposed to support running Alertmanager under heavier load

Tuning these parameters is useful when alertmanager is under heavy load

Which issue(s) this PR fixes or relates to

Fixes https://github.com/grafana/mimir-squad/issues/578

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…rency

Tuning these parameters is useful when alertmanager is under heavy load
@stevesg stevesg self-requested a review March 25, 2022 08:53
@gotjosh gotjosh self-requested a review March 25, 2022 16:03
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/alertmanager/multitenant.go Outdated Show resolved Hide resolved
pkg/alertmanager/multitenant.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please see my nits.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo few nits)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Logiraptor and others added 2 commits March 30, 2022 09:45
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@CLAassistant
Copy link

CLAassistant commented Mar 30, 2022

CLA assistant check
All committers have signed the CLA.

Logiraptor and others added 2 commits March 30, 2022 09:45
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job, let's go!

@pracucci pracucci merged commit 180ff05 into main Mar 31, 2022
@pracucci pracucci deleted the logiraptor/add-am-grpc-concurrency-configuration branch March 31, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants