Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsonnet configuration settings that match default values #1915

Merged
merged 2 commits into from
May 24, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
* [BUGFIX] Fix `MimirCompactorHasNotUploadedBlocks` alert false positive when Mimir is deployed in monolithic mode. #1901
* [BUGFIX] Do not trigger `MimirAllocatingTooMuchMemory` alerts if no container limits are supplied. #1905

### Jsonnet

* [CHANGE] Remove use of `querier.query-store-after` and `blocks-storage.bucket-store.ignore-blocks-within` CLI flags since the values now match defaults. #1915
pracucci marked this conversation as resolved.
Show resolved Hide resolved

## 2.1.0-rc.0

### Grafana Mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Configure Grafana Mimir so large tenants are parallelized by the compactor:

#### How to estimate `-querier.query-store-after`

If not using the defaults, set the `-querier.query-store-after` to a duration that is large enough to give compactor enough time to compact newly uploaded blocks, and queriers and store-gateways to discover and synchronize newly compacted blocks.
If you are not using the defaults, set the `-querier.query-store-after` to a duration that is large enough to give compactor enough time to compact newly uploaded blocks, and queriers and store-gateways to discover and synchronize newly compacted blocks.

The following diagram shows all of the timings involved in the estimation. This diagram should be used only as a template and you can modify the assumptions based on real measurements in your Mimir cluster. The example makes the following assumptions:

Expand Down
2 changes: 0 additions & 2 deletions operations/mimir-tests/test-defaults-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
- -server.grpc.keepalive.ping-without-stream-allowed=true
Expand Down Expand Up @@ -1316,7 +1315,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1075,7 +1074,6 @@ spec:
- -ingester.ring.replication-factor=3
- -ingester.ring.store=consul
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -1646,7 +1644,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
3 changes: 0 additions & 3 deletions operations/mimir-tests/test-gossip-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1112,7 +1111,6 @@ spec:
- -memberlist.bind-port=7946
- -memberlist.join=gossip-ring.default.svc.cluster.local:7946
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -1692,7 +1690,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1323,7 +1322,6 @@ spec:
- -memberlist.bind-port=7946
- -memberlist.join=gossip-ring.default.svc.cluster.local:7946
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -2164,7 +2162,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2295,7 +2292,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2426,7 +2422,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
3 changes: 0 additions & 3 deletions operations/mimir-tests/test-gossip-multikv-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1130,7 +1129,6 @@ spec:
- -memberlist.bind-port=7946
- -memberlist.join=gossip-ring.default.svc.cluster.local:7946
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -1722,7 +1720,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1130,7 +1129,6 @@ spec:
- -memberlist.bind-port=7946
- -memberlist.join=gossip-ring.default.svc.cluster.local:7946
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -1722,7 +1720,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1115,7 +1114,6 @@ spec:
- -memberlist.bind-port=7946
- -memberlist.join=gossip-ring.default.svc.cluster.local:7946
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -1695,7 +1693,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1579,7 +1578,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
5 changes: 0 additions & 5 deletions operations/mimir-tests/test-multi-zone-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1273,7 +1272,6 @@ spec:
- -ingester.ring.store=consul
- -ingester.ring.zone-awareness-enabled=true
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -2095,7 +2093,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2221,7 +2218,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2347,7 +2343,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,6 @@ spec:
- -querier.frontend-client.grpc-max-send-msg-size=104857600
- -querier.max-concurrent=8
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -querier.scheduler-address=query-scheduler-discovery.default.svc.cluster.local:9095
- -runtime-config.file=/etc/mimir/overrides.yaml
- -server.grpc.keepalive.min-time-between-pings=10s
Expand Down Expand Up @@ -1335,7 +1334,6 @@ spec:
- -ingester.ring.store=consul
- -ingester.ring.zone-awareness-enabled=true
- -querier.query-ingesters-within=13h
- -querier.query-store-after=12h
- -ruler-storage.backend=gcs
- -ruler-storage.gcs.bucket-name=rules-bucket
- -ruler.alertmanager-url=http://alertmanager.default.svc.cluster.local/alertmanager
Expand Down Expand Up @@ -2246,7 +2244,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2369,7 +2366,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2495,7 +2491,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2621,7 +2616,6 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.ignore-blocks-within=10h
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
Expand Down
Loading