mixin: adapt alerts/playbooks to consider ruler query path components #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortuman
added
type/docs
ortuman
force-pushed
the
ortuman/mixin-ruler-query-path-alerts
branch
from
12ae35e
to
e55e286
Compare
pracucci
reviewed
May 31, 2022
ortuman
force-pushed
the
ortuman/mixin-ruler-query-path-alerts
branch
2 times, most recently
from
ed93e88
to
638ab32
Compare
stevesg
reviewed
Jun 1, 2022
…path components. Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ortuman
force-pushed
the
ortuman/mixin-ruler-query-path-alerts
branch
from
0d506b7
to
083b08a
Compare
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
stevesg
approved these changes
Jun 8, 2022
|
Taking a final look too. |
pracucci
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Ángel Ortuño ortuman@gmail.com
What this PR does
Add extra alerts for ruler query path components and adapt current ones to avoid conflicting with regular query path.
Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]