Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Add test-enterprise for Helm CI #2027

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

Logiraptor
Copy link
Contributor

@Logiraptor Logiraptor commented Jun 3, 2022

What this PR does

Adds a bare-bones test values file with enterprise.enabled set to true. This will at least validate that the manifests are valid and can be installed to k8s under enterprise mode.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@Logiraptor Logiraptor marked this pull request as ready for review June 3, 2022 20:02
@Logiraptor Logiraptor requested a review from krajorama June 3, 2022 20:21
@krajorama
Copy link
Contributor

no need for the version bump anymore

@Logiraptor Logiraptor force-pushed the logiraptor/helm-test-enterprise branch from f865aeb to f478ee7 Compare June 6, 2022 14:13
@Logiraptor
Copy link
Contributor Author

@krajorama I removed the version bump related changes. Can you take a look?

Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@treid314 treid314 merged commit a76e296 into main Jun 6, 2022
@treid314 treid314 deleted the logiraptor/helm-test-enterprise branch June 6, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants