Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add some jsonnet utilities to reduce code duplication #2039

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Jun 7, 2022

What this PR does

I'm working on a experiment to deploy Mimir in simple scalable deployment mode (similar to Loki) and I'm finding myself copy-pasting some jsonnet. I would like to introduce some utilities.

In separate commits:

This PR is expected to be a no-op with regards to the generated manifests.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. ❤️

@pracucci pracucci merged commit 8415eb1 into main Jun 7, 2022
@pracucci pracucci deleted the add-jsonnet-utils branch June 7, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants