Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimir-continuous-test: Add smoke test mode #2047

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

Logiraptor
Copy link
Contributor

What this PR does

Adds a new flag -tests.smoke-test to mimir-continuous-test. This flag will run the tests once and immediately exit.

The existing test was updated to support returning errors to the caller. In order to maximize the amount of useful debugging information returned, errors are collected in a slice and returned all at once rather than exiting at the first error.

Which issue(s) this PR fixes or relates to

Fixes #2042

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@Logiraptor Logiraptor added the component/continuous-test mimir-continuous-test related work label Jun 7, 2022
@Logiraptor Logiraptor requested a review from pracucci June 7, 2022 19:15
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I just left a couple of tiny comments. Feel free to merge once addressed. Thanks!

pkg/continuoustest/write_read_series.go Outdated Show resolved Hide resolved
pkg/continuoustest/write_read_series.go Outdated Show resolved Hide resolved
@Logiraptor Logiraptor merged commit 29142fc into main Jun 8, 2022
@Logiraptor Logiraptor deleted the logiraptor/contest-smoke-test-mode branch June 8, 2022 15:18
@pstibrany pstibrany mentioned this pull request Jun 13, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/continuous-test mimir-continuous-test related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mimir-continuous-test should be able to run a one-time smoke test
2 participants