Return and log detailed services information on /ready #2055
Conversation
This helps debug starting services more easily. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
| } | ||
|
|
||
| http.Error(w, msg.String(), http.StatusServiceUnavailable) | ||
| strMsg := msg.String() | ||
| level.Debug(util_log.Logger).Log(strMsg) |
There was a problem hiding this comment.
There is no need to debug-log this.
There was a problem hiding this comment.
My original thinking was that this should make it easier to see why components aren't ready - no need to port-forward to pods and curl endpoints - it will be in the logs.
Do you think that would be useful?
There was a problem hiding this comment.
We already have logs for each starting/started module, which can be used to find out which modules aren't ready.
If we change this log line to only log non-ready modules, I think it would be more useful than logging ALL modules.
There was a problem hiding this comment.
If we change this log line to only log non-ready modules, I think it would be more useful than logging ALL modules.
agreed, pushed a change in d214659
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com
What this PR does
The
/readywill now include each service's state when there is at least one non-Runningservice (e.g.FailedorStarting). The same will be logged at debug level.Previously output:
Current output:
Which issue(s) this PR fixes or relates to
Fixes #1780
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]