Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ruler endpoints #2182

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Jun 22, 2022

What this PR does

Removes /api/v1/rules* and /prometheus/rules* endpoints in preparation
for the 2.2.0 release. Replaces their usages throughout the repo with
/prometheus/config/v1/rules*.

These two endpoints were deprecated with the 2.0.0 release and prepared for deletion as outlined in the HTTP API documentation and the about-versioning.md doc.

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Removes /api/v1/rules* and /prometheus/rules* endpoints in preparation
for the 2.2.0 release. Replaces their usages throughout the repo with
/prometheus/config/v1/rules*

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov
Copy link
Contributor Author

hm, this change also includes changes to mimirtool's --use-legacy-endpoints. I added a chagnelog entry for that too

@pstibrany pstibrany enabled auto-merge (squash) June 24, 2022 09:33
@pstibrany pstibrany merged commit deed107 into main Jun 24, 2022
@pstibrany pstibrany deleted the dimitar/remove-deprecated-ruler-endpoints branch June 24, 2022 09:38
masonmei pushed a commit to udmire/mimir that referenced this pull request Jul 11, 2022
* Remove deprecated ruler endpoints

Removes /api/v1/rules* and /prometheus/rules* endpoints in preparation
for the 2.2.0 release. Replaces their usages throughout the repo with
/prometheus/config/v1/rules*

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Add changelog entry

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix failing tests

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Add changelog entry for mimirtool

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants