[ruler] Remove unused fields #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
remove-unused-fields
branch
from
a404d73
to
1211a34
Compare
pracucci
reviewed
Jun 30, 2022
I was helping someone debug notifications being sent every min and we found that these two fields are not used anywhere at all. I am not sure of the deprecation and breaking change policy. Should I mark them deprecated somehow and then remove them or just remove them right away since they are not being used. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
remove-unused-fields
branch
from
1211a34
to
44d696a
Compare
|
Done! |
56quarters
approved these changes
Jun 30, 2022
osg-grafana
approved these changes
Jul 4, 2022
jhesketh
approved these changes
Jul 4, 2022
Yeah, I wouldn't go through the deprecation policy given they're unused. |
pracucci
reviewed
Jul 4, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* [ruler] Remove unused fields I was helping someone debug notifications being sent every min and we found that these two fields are not used anywhere at all. I am not sure of the deprecation and breaking change policy. Should I mark them deprecated somehow and then remove them or just remove them right away since they are not being used. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was helping someone debug notifications being sent every min and we found that
these two fields are not used anywhere at all.
I am not sure of the deprecation and breaking change policy. Should I mark them
deprecated somehow and then remove them or just remove them right away since they
are not being used.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]