Fix sharding of vector and time functions
#2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colega
force-pushed
the
fix-vector-and-time-sharding
branch
2 times, most recently
from
62374a8
to
b4c0aed
Compare
Functions `vector` and `time` can't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later. Additionally, functions that have a default `time()` argument, like `month()`, were not propagating the shardeability checks properly. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
force-pushed
the
fix-vector-and-time-sharding
branch
from
b4c0aed
to
06ecf5a
Compare
stevesg
pushed a commit
that referenced
this pull request
Jul 11, 2022
Functions `vector` and `time` can't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later. Additionally, functions that have a default `time()` argument, like `month()`, were not propagating the shardeability checks properly. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> (cherry picked from commit 27154b3)
colega
added a commit
that referenced
this pull request
Jul 11, 2022
Functions `vector` and `time` can't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later. Additionally, functions that have a default `time()` argument, like `month()`, were not propagating the shardeability checks properly. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> (cherry picked from commit 27154b3) Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
that referenced
this pull request
Jul 11, 2022
Functions `vector` and `time` can't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later. Additionally, functions that have a default `time()` argument, like `month()`, were not propagating the shardeability checks properly. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> (cherry picked from commit 27154b3) Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
stevesg
pushed a commit
that referenced
this pull request
Jul 13, 2022
Functions `vector` and `time` can't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later. Additionally, functions that have a default `time()` argument, like `month()`, were not propagating the shardeability checks properly. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> (cherry picked from commit 27154b3)
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 25, 2022
…#2361) Functions `vector` and `time` can't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later. Additionally, functions that have a default `time()` argument, like `month()`, were not propagating the shardeability checks properly. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> (cherry picked from commit 27154b3) Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Functions
vectorandtimecan't be sharded, as they produce same set of series (with zero labels) and can't be concatenated later.Additionally, functions that have a default
time()argument, likemonth(), were not propagating the shardeability checks properly.Which issue(s) this PR fixes or relates to
None, internal.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]