Implement tenant federation for metadata querier endpoint #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/federated-metadata
branch
2 times, most recently
from
1217a0a
to
72bc1f4
Compare
56quarters
commented
Jul 19, 2022
Allow multiple tenant IDs to be passed to the `/api/v1/metadata` endpoint in the same way we support for query and exemplar endpoints. For other endpoints, the tenant ID is included as a generated label (query results or exemplars). We don't have the option here because metadata doesn't include any labels. Because of this we simply merge metadata for all tenants. The `http.Handler` will group all metadata under each metric name. Fixes #2410 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/federated-metadata
branch
from
72bc1f4
to
44579de
Compare
pstibrany
approved these changes
Jul 20, 2022
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
|
Actually, I missed this part of the Prometheus docs that specifies that metadata has to be unique. I'll push a commit that fixes this shortly:
From https://prometheus.io/docs/prometheus/latest/querying/api/#querying-metric-metadata |
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
replay
reviewed
Jul 20, 2022
replay
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
What this PR does
Allow multiple tenant IDs to be passed to the
/api/v1/metadataendpoint in the same way we support for query and exemplar endpoints.
For other endpoints, the tenant ID is included as a generated label
(query results or exemplars). We don't have the option here because
metadata doesn't include any labels. Because of this we simply merge
and de-duplicate metadata for all tenants. The
http.Handlerwill groupall metadata under each metric name.
Which issue(s) this PR fixes or relates to
Fixes #2410
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]