Split start and finish block upload endpoints. #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
3 tasks
56quarters
reviewed
Jul 20, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pracucci
approved these changes
Jul 20, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR splits existing block upload endpoint
/api/v1/upload/block/{block}into two:/api/v1/upload/block/{block}/start/api/v1/upload/block/{block}/finishPrimary motivation is that in PR #2471 we are going to change output of
/api/v1/upload/block/{block}/finishto send progress of validation, and handling both operations in single handler, each with different outputs was cumbersome."start" only returns HTTP status code, while "finish" will send HTTP status code but also json objects, and client will need to parse the output to discover if upload of the block finished successfully or not. (This will be true after #2471 is ready)
Note that block upload API is still experimental and subject to change.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]