Changed -compactor.max-compaction-time default from 0s to 1h #2514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I propose to change -compactor.max-compaction-time default from 0s to 1h, to aim for a better fairness between tenants (when running a small number of compactor replicas) and address #2302 too.
I think enabling it (and setting to 1h) doesn't have any significant downside. For example, let's consider a single tenant cluster, with very long compactions. After 1h in a compaction cycle, the compactor stops compacting more blocks. However, since
-compactor.compaction-interval=1h
, the ticker already put a message in the channel so the next compaction cycle starts right after the previous one ended because the 1h limit has been reached. Basically, excluding the time it takes to scan the bucket, there's no expected "delay" introduced by setting-compactor.max-compaction-time
when it triggers. Makes sense?Which issue(s) this PR fixes or relates to
Part of #2302
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]