Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor block upload: Check block upload endpoint #2548

Merged
merged 6 commits into from
Jul 26, 2022

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Jul 26, 2022

What this PR does

This PR adds endpoint to check state of block upload.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany added the type/docs Improvements or additions to documentation label Jul 26, 2022
pstibrany and others added 2 commits July 26, 2022 15:54
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
renamed `marshalAndUploadJson` to `marshalAndUploadJSON` to address golint issue
Copy link
Contributor

@aldernero aldernero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany
Copy link
Member Author

Merging to ease conflicts with other backfill work, but will address any additional review feedback (esp. in docs).

@pstibrany pstibrany merged commit 8ca3ed6 into main Jul 26, 2022
@pstibrany pstibrany deleted the check-upload-endpoint branch July 26, 2022 15:28
@aldernero aldernero mentioned this pull request Jul 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants