Remove extend_writes from Distributor YAML config
#2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mentioned to be removed in 2.3, so this is a good time to do it. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
force-pushed
the
remove-extend-writes-yaml-key-from-distributor-config
branch
from
355da3f
to
fd0f008
Compare
56quarters
approved these changes
Jul 26, 2022
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| * [CHANGE] Change default value for `-distributor.ha-tracker.max-clusters` to `100` to provide a DoS protection. #2465 | |||
| * [CHANGE] Experimental block upload API exposed by compactor has changed: Previous `/api/v1/upload/block/{block}` endpoint for starting block upload is now `/api/v1/upload/block/{block}/start`, and previous endpoint `/api/v1/upload/block/{block}?uploadComplete=true` for finishing block upload is now `/api/v1/upload/block/{block}/finish`. #2486 | |||
| * [CHANGE] Compactor: changed `-compactor.max-compaction-time` default from `0s` (disabled) to `1h`. When compacting blocks for a tenant, the compactor will move to compact blocks of another tenant or re-plan blocks to compact at least every 1h. #2514 | |||
| * [CHANGE] Distributor: removed previously deprecated `extend_writes` (see #3719) YAML key from the Distributor config. #2551 | |||
There was a problem hiding this comment.
Doesn't seem like that issue/PR exists in Mimir. There is a related Cortex issue but it doesn't seem like it deprecates the option.
There was a problem hiding this comment.
Just force-pushed, I referenced the wrong issue. Good catch :)
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
@56quarters re-requested review since I also removed the deprecated flag. |
56quarters
approved these changes
Jul 26, 2022
Oh, right! I guess that's kind of important 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mentioned to be removed in 2.3, so this is a good time to do it.
Signed-off-by: Oleg Zaytsev mail@olegzaytsev.com