Improved query-frontend instant query splitting metrics #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Jul 28, 2022
| Namespace: "cortex", | ||
| Name: "frontend_query_sharding_rewrites_attempted_total", | ||
| Help: "Total number of queries the query-frontend attempted to shard.", | ||
| Name: "cortex_frontend_query_sharding_rewrites_attempted_total", |
There was a problem hiding this comment.
Note to reviewers: it makes the metrics easier to grep / find.
pracucci
commented
Jul 28, 2022
| }), | ||
| } | ||
|
|
||
| // Initialize known label values. |
There was a problem hiding this comment.
Note to reviewers: this is a Prometheus best practice, so that metrics are exposed even if they have 0 value.
pracucci
commented
Jul 28, 2022
| @@ -268,35 +264,36 @@ func TestQuerySplittingCorrectness(t *testing.T) { | |||
| approximatelyEquals(t, expectedPrometheusRes, splitPrometheusRes) | |||
|
|
|||
| // Assert metrics | |||
| assert.NoError(t, testutil.GatherAndCompare(reg, strings.NewReader(` | |||
There was a problem hiding this comment.
Note to reviewers: I merged the metrics assertions into a single one.
ssncferreira
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I'm proposing a couple of changes to query-frontend instant query splitting metrics:
evaluationlabel fromcortex_frontend_instant_query_splitting_rewrites_succeeded_totalmetric, and keep it focused on succeeded rewrites (so that it matches its metric name)cortex_frontend_instant_query_splitting_rewrites_skipped_totalto track metrics which haven't been split, for anyreason(adding theparsing-failedreason too, otherwise the count of successes + skipped doesn't matchcortex_frontend_query_sharding_rewrites_attempted_total)Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]