Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set unlimited max concurrency in PromQL engine #2598

Merged
merged 7 commits into from
Aug 19, 2022
Merged

Set unlimited max concurrency in PromQL engine #2598

merged 7 commits into from
Aug 19, 2022

Conversation

hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Jul 29, 2022 •
edited
Loading

What this PR does

Set unlimited max concurrency in PromQL engine and update test.

Which issue(s) this PR fixes or relates to

Fixes #1298

Checklist

  • Tests updated
  • Documentation updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@hi-rustin
Copy link
Contributor Author

@pracucci Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

@pracucci pracucci self-requested a review August 8, 2022 10:50
pracucci
pracucci reviewed Aug 8, 2022
View reviewed changes
pkg/querier/worker/worker.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/querier/engine/query_tracker.go Outdated Show resolved Hide resolved
@hi-rustin hi-rustin requested review from pracucci and removed request for dimitarvdimitrov August 19, 2022 12:59
pracucci
pracucci approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left few final suggestion I'm just going to self-apply.

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/querier/engine/query_tracker.go Outdated Show resolved Hide resolved
pkg/querier/engine/query_tracker_test.go Outdated Show resolved Hide resolved
docs/sources/operators-guide/architecture/components/query-frontend/index.md Outdated Show resolved Hide resolved
docs/sources/operators-guide/architecture/components/query-frontend/index.md Outdated Show resolved Hide resolved
@hi-rustin
Copy link
Contributor Author

Thanks for your review! 💚 💙 💜 💛 ❤️

@pracucci pracucci merged commit 6136dc4 into grafana:main Aug 19, 2022
@hi-rustin hi-rustin deleted the rustin-patch-querier branch August 19, 2022 16:17
@pracucci pracucci mentioned this pull request Sep 20, 2022
Merged
3 tasks
@aknuds1 aknuds1 mentioned this pull request Dec 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov left review comments

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: set unlimited max concurrency in PromQL engine
3 participants
@hi-rustin @pracucci @dimitarvdimitrov