Build: Upgrade to Go 1.19.1 #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
chore/upgrade-go
branch
4 times, most recently
from
30a1783
to
75c0b0b
Compare
|
Given golang 1.19.0 has just been released, maybe we could wait to merge this PR after 2.3.0 is cut? I would prefer to not build the next Mimir stable release with a just-released golang version. |
@pracucci I think we want to wait for a few patch upgrades to Go 1.19. I made the (draft) PR in order to prepare, golangci-lint doesn't even work yet :) |
aknuds1
force-pushed
the
chore/upgrade-go
branch
5 times, most recently
from
50092c0
to
b7fbda4
Compare
aknuds1
force-pushed
the
chore/upgrade-go
branch
2 times, most recently
from
2f4d3d9
to
94a1ba7
Compare
aknuds1
force-pushed
the
chore/upgrade-go
branch
5 times, most recently
from
906376f
to
886eb30
Compare
aknuds1
force-pushed
the
chore/upgrade-go
branch
3 times, most recently
from
26aa583
to
d6801fe
Compare
pstibrany
reviewed
Sep 8, 2022
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/upgrade-go
branch
from
7aaec07
to
34165b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrade to build with Go 1.19.1.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]