Move purger API endpoints to compactor #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviHarrison
force-pushed
the
move-purger-to-compactor
branch
2 times, most recently
from
eaceb02
to
792cefb
Compare
pracucci
reviewed
Aug 4, 2022
There was a problem hiding this comment.
Thanks for working on this! What you did is just right 👍
Note to reviewers: this breaking change is allowed because tenant deletion APIs are still marked as experimental.
Few more comments:
- Please update
docs/sources/operators-guide/configure/about-versioning.md. We mention "Purger: Tenant deletion API". It should be moved under "Compactor" section in the list. - Please remove the purger from
development/tsdb-blocks-storage-s3/andintegration/
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
LeviHarrison
force-pushed
the
move-purger-to-compactor
branch
from
2ac307a
to
fe9f0c3
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR moves the purger API endpoints to the compactor component.
There are two implementation decisions I made but am not entirely sure about:
/compactor, not/purger.TenantDeletion. When transferring over the endpoints I merged them directly into theCompactormodule instead of keeping the separateTenantDeletionmodule. My reasoning was that none of the other compactor API endpoints are part of a separate module.Which issue(s) this PR fixes or relates to
Fixes #2190
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]